Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/rest-api): remove alarms info from the dashboard and messages endpoint #7959

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 3, 2024

Description

⚠️ alarms info is removed from the dashboard endpoint! ⚠️
Alarms are now in a dedicated endpoint /alarms

// /alarms
string[]

// /alarms/<uuid>
{
   body: {
      value: string, // NaN, Infinity and -Infinity aren't valid JSON
      name: string
   },
   name: 'ALARM',
   time: number,
   $object: string,
   id: string,
   type: 'message',
   uuid: string,
   $pool: string,
   $poolId: string,
   _xapiRef: string,
   object: {
      type: string,
      uuid: string,
      href: string | undefined
   },
}

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Sep 3, 2024
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA marked this pull request as ready for review September 5, 2024 12:25
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
packages/xo-server/src/xo-mixins/rest-api.mjs Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested review from b-Nollet and removed request for julien-f September 24, 2024 12:34
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Co-authored-by: Julien Fontanet <[email protected]>
@MathieuRA MathieuRA changed the title fix(xo-server/rest-api): remove alarms information in the dashboard endpoint fix(xo-server/rest-api): remove alarms info from the dashboard and messages endpoint Sep 25, 2024
@MathieuRA MathieuRA merged commit 971a561 into master Sep 25, 2024
1 check passed
@MathieuRA MathieuRA deleted the dashboard-remove-alarms branch September 25, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants